From 5c8f65b9ca3a7db5331083acf7808282a01aa74c Mon Sep 17 00:00:00 2001 From: Martin Sucha Date: Sun, 20 May 2018 21:01:31 +0200 Subject: [PATCH] crypto/x509: reformat template members in docs It's easier to skim a list of items visually when the items are each on a separate line. Separate lines also help reduce diff size when items are added/removed. The list is indented so that it's displayed preformatted in HTML output as godoc doesn't support formatting lists natively yet (see #7873). Change-Id: Ibf9e92437e4b464ba58ea3ccef579e8df4745d75 Reviewed-on: https://go-review.googlesource.com/113915 Reviewed-by: Brad Fitzpatrick --- src/crypto/x509/x509.go | 40 ++++++++++++++++++++++++++++++++-------- 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/src/crypto/x509/x509.go b/src/crypto/x509/x509.go index dcebce320d..bb1f94497f 100644 --- a/src/crypto/x509/x509.go +++ b/src/crypto/x509/x509.go @@ -2039,11 +2039,26 @@ func signingParamsForPublicKey(pub interface{}, requestedSigAlgo SignatureAlgori var emptyASN1Subject = []byte{0x30, 0} // CreateCertificate creates a new X.509v3 certificate based on a template. -// The following members of template are used: AuthorityKeyId, -// BasicConstraintsValid, DNSNames, ExcludedDNSDomains, ExtKeyUsage, -// IsCA, KeyUsage, MaxPathLen, MaxPathLenZero, NotAfter, NotBefore, -// PermittedDNSDomains, PermittedDNSDomainsCritical, SerialNumber, -// SignatureAlgorithm, Subject, SubjectKeyId, and UnknownExtKeyUsage. +// The following members of template are used: +// +// - AuthorityKeyId +// - BasicConstraintsValid +// - DNSNames +// - ExcludedDNSDomains +// - ExtKeyUsage +// - IsCA +// - KeyUsage +// - MaxPathLen +// - MaxPathLenZero +// - NotAfter +// - NotBefore +// - PermittedDNSDomains +// - PermittedDNSDomainsCritical +// - SerialNumber +// - SignatureAlgorithm +// - Subject +// - SubjectKeyId +// - UnknownExtKeyUsage // // The certificate is signed by parent. If parent is equal to template then the // certificate is self-signed. The parameter pub is the public key of the @@ -2365,9 +2380,18 @@ func parseCSRExtensions(rawAttributes []asn1.RawValue) ([]pkix.Extension, error) } // CreateCertificateRequest creates a new certificate request based on a -// template. The following members of template are used: Attributes, DNSNames, -// EmailAddresses, ExtraExtensions, IPAddresses, URIs, SignatureAlgorithm, and -// Subject. The private key is the private key of the signer. +// template. The following members of template are used: +// +// - Attributes +// - DNSNames +// - EmailAddresses +// - ExtraExtensions +// - IPAddresses +// - URIs +// - SignatureAlgorithm +// - Subject +// +// The private key is the private key of the signer. // // The returned slice is the certificate request in DER encoding. // -- 2.48.1