From 5d16f9751a1b947308d6ac4ab51c85c28e8c067d Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 7 Jul 2017 19:49:33 +0000 Subject: [PATCH] Revert "cmd/dist: disable plugin test on linux-arm with GOARM=5" This reverts commit 168eb9cf3395583541224af0227c19ddb13e35be. CL 47831 fixes the issue with plugins on ARMv5, so we can re-enable the test. Updates #19674. Change-Id: Idcb29f93ffb0460413f1fab5bb82fa2605795038 Reviewed-on: https://go-review.googlesource.com/47834 Reviewed-by: Brad Fitzpatrick --- src/cmd/dist/test.go | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index b56495e723..a2a5126d2d 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -60,7 +60,6 @@ type tester struct { goroot string goarch string gohostarch string - goarm string goos string gohostos string cgoEnabled bool @@ -104,7 +103,6 @@ func (t *tester) run() { t.gohostos = mustEnv("GOHOSTOS") t.goarch = mustEnv("GOARCH") t.gohostarch = mustEnv("GOHOSTARCH") - t.goarm = os.Getenv("GOARM") slurp, err := exec.Command("go", "env", "CGO_ENABLED").Output() if err != nil { log.Fatalf("Error running go env CGO_ENABLED: %v", err) @@ -800,12 +798,6 @@ func (t *tester) supportedBuildmode(mode string) bool { return false } - if pair == "linux-arm" && t.goarm == "5" { - // Skip the plugin tests for now on ARMv5 because it causes a - // SIGILL. See https://golang.org/issue/19674 - return false - } - // linux-arm64 is missing because it causes the external linker // to crash, see https://golang.org/issue/17138 switch pair { -- 2.50.0