From 5f15af111cb40c3ac154be88288abd381e6f61e2 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Fri, 15 Jan 2021 09:48:39 -0500 Subject: [PATCH] syscall: comment on fields omitted from the win32finddata1 struct Updates #42637 Change-Id: I4c7d38034b60c2c04efdeb530a97d96deddfd6fe Reviewed-on: https://go-review.googlesource.com/c/go/+/284152 Trust: Bryan C. Mills Trust: Jason A. Donenfeld Trust: Alex Brainman Run-TryBot: Bryan C. Mills TryBot-Result: Go Bot Reviewed-by: Jason A. Donenfeld Reviewed-by: Alex Brainman --- src/syscall/types_windows.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/syscall/types_windows.go b/src/syscall/types_windows.go index 0349f3b180..5fef5c9477 100644 --- a/src/syscall/types_windows.go +++ b/src/syscall/types_windows.go @@ -398,6 +398,14 @@ type win32finddata1 struct { Reserved1 uint32 FileName [MAX_PATH]uint16 AlternateFileName [14]uint16 + + // The Microsoft documentation for this struct¹ describes three additional + // fields: dwFileType, dwCreatorType, and wFinderFlags. However, those fields + // are empirically only present in the macOS port of the Win32 API,² and thus + // not needed for binaries built for Windows. + // + // ¹ https://docs.microsoft.com/en-us/windows/win32/api/minwinbase/ns-minwinbase-win32_find_dataw + // ² https://golang.org/issue/42637#issuecomment-760715755 } func copyFindData(dst *Win32finddata, src *win32finddata1) { -- 2.50.0