From 622780b1c1ba73a5e61d26949bbdcc33851d7709 Mon Sep 17 00:00:00 2001 From: Tamir Duberstein Date: Fri, 26 Feb 2016 18:26:04 -0500 Subject: [PATCH] crypto/tls: don't log expected errors in test This is minor cleanup that reduces test output noise. Change-Id: Ib6db4daf8cb67b7784b2d5b222fa37c7f78a6a04 Reviewed-on: https://go-review.googlesource.com/19997 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/crypto/tls/handshake_server_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/crypto/tls/handshake_server_test.go b/src/crypto/tls/handshake_server_test.go index e25bfa5170..74ad72a848 100644 --- a/src/crypto/tls/handshake_server_test.go +++ b/src/crypto/tls/handshake_server_test.go @@ -518,16 +518,17 @@ func (test *serverTest) run(t *testing.T, write bool) { server := Server(serverConn, config) connStateChan := make(chan ConnectionState, 1) go func() { - var err error - if _, err = server.Write([]byte("hello, world\n")); err != nil { - t.Logf("Error from Server.Write: %s", err) - } + _, err := server.Write([]byte("hello, world\n")) if len(test.expectHandshakeErrorIncluding) > 0 { if err == nil { t.Errorf("Error expected, but no error returned") } else if s := err.Error(); !strings.Contains(s, test.expectHandshakeErrorIncluding) { t.Errorf("Error expected containing '%s' but got '%s'", test.expectHandshakeErrorIncluding, s) } + } else { + if err != nil { + t.Logf("Error from Server.Write: '%s'", err) + } } server.Close() serverConn.Close() -- 2.48.1