From 626a3cd9fa6ea412aa8ccd5f33ca836fa4ca116f Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Mon, 28 Aug 2023 11:26:17 -0700 Subject: [PATCH] cmd/go: only print cgo.Incomplete warning if -x Change-Id: I1e0476d6d67f0b2d3d4ad487c2619e3d09f485d5 Reviewed-on: https://go-review.googlesource.com/c/go/+/523576 Commit-Queue: Ian Lance Taylor Reviewed-by: Austin Clements Reviewed-by: Ian Lance Taylor Auto-Submit: Ian Lance Taylor TryBot-Result: Gopher Robot Run-TryBot: Ian Lance Taylor Auto-Submit: Ian Lance Taylor --- src/cmd/go/internal/work/gccgo.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/go/internal/work/gccgo.go b/src/cmd/go/internal/work/gccgo.go index 69fc04a1ab..dcc779ee97 100644 --- a/src/cmd/go/internal/work/gccgo.go +++ b/src/cmd/go/internal/work/gccgo.go @@ -658,8 +658,8 @@ func (tools gccgoToolchain) supportsCgoIncomplete(b *Builder) bool { cmd.Stdout = &buf cmd.Stderr = &buf err = cmd.Run() - if out := buf.String(); len(out) > 0 { - b.showOutput(nil, tmpdir, b.fmtcmd(tmpdir, "%s -c -o %s %s", tools.compiler(), on, fn), buf.String()) + if out := buf.String(); len(out) > 0 && cfg.BuildX { + b.showOutput(nil, tmpdir, b.fmtcmd(tmpdir, "%s -c -o %s %s", tools.compiler(), on, fn), out) } gccgoSupportsCgoIncomplete = err == nil }) -- 2.48.1