From 641ef2a73392b01382d7b2ffd34820fa36f5f9cf Mon Sep 17 00:00:00 2001 From: Joe Tsai Date: Tue, 10 Jan 2017 23:13:45 -0800 Subject: [PATCH] compress/gzip: skip TestGZIPFilesHaveZeroMTimes on non-builders Fixes #18604 Change-Id: I89221d5e632042167dfced068e1dc14e932cd618 Reviewed-on: https://go-review.googlesource.com/35111 Run-TryBot: Joe Tsai TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/compress/gzip/issue14937_test.go | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/compress/gzip/issue14937_test.go b/src/compress/gzip/issue14937_test.go index e76d47cc4e..30c1390dfd 100644 --- a/src/compress/gzip/issue14937_test.go +++ b/src/compress/gzip/issue14937_test.go @@ -9,11 +9,17 @@ import ( "testing" ) -// Per golang.org/issue/14937, check that every .gz file -// in the tree has a zero mtime. +// TestGZIPFilesHaveZeroMTimes checks that every .gz file in the tree +// has a zero MTIME. This is a requirement for the Debian maintainers +// to be able to have deterministic packages. +// +// See https://golang.org/issue/14937. func TestGZIPFilesHaveZeroMTimes(t *testing.T) { - if testing.Short() && testenv.Builder() == "" { - t.Skip("skipping in short mode") + // To avoid spurious false positives due to untracked GZIP files that + // may be in the user's GOROOT (Issue 18604), we only run this test on + // the builders, which should have a clean checkout of the tree. + if testenv.Builder() == "" { + t.Skip("skipping test on non-builder") } goroot, err := filepath.EvalSymlinks(runtime.GOROOT()) if err != nil { -- 2.48.1