From 64c5280844aa7d6cbec18c47750f9d3e65f5f72a Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Thu, 2 Feb 2017 20:37:29 -0500 Subject: [PATCH] net/http: fix dns hijacking test The name lookups are unrooted; the test should be unrooted too. Correctly skips the tests if the DNS config specifies a domain suffix that has a wildcard entry causing all unrooted names to resolve. Change-Id: I80470326a5d332f3b8d64663f765fd304c5e0811 Reviewed-on: https://go-review.googlesource.com/36253 Run-TryBot: Russ Cox TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/net/http/transport_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go index e3de3eb91b..085bb3cd4b 100644 --- a/src/net/http/transport_test.go +++ b/src/net/http/transport_test.go @@ -3436,7 +3436,7 @@ func skipIfDNSHijacked(t *testing.T) { // DNS server hijacking queries. // See issues 16732, 16716. isDNSHijackedOnce.Do(func() { - addrs, _ := net.LookupHost("dns-should-not-resolve.golang.") + addrs, _ := net.LookupHost("dns-should-not-resolve.golang") isDNSHijacked = len(addrs) != 0 }) if isDNSHijacked { -- 2.48.1