From 653abefddf2c627d5d1805d35e55c5a01eb32c6e Mon Sep 17 00:00:00 2001 From: sivchari Date: Tue, 1 Aug 2023 05:00:52 +0000 Subject: [PATCH] cmd/go/internal/load: improve comments isTestFunc checked whether the parameter type is B, M or T before the version of Go1.17. But, after Go1.18, isTestFunc checks F, too. Change-Id: I30bc97c2b8f2974bc9ae4df2f32dc8dce760d7d6 GitHub-Last-Rev: 507d5b1f74b2f2d0a75d61fe169cc0cc40d132c0 GitHub-Pull-Request: golang/go#56127 Reviewed-on: https://go-review.googlesource.com/c/go/+/441835 Reviewed-by: Michael Matloob Reviewed-by: Bryan Mills Auto-Submit: Bryan Mills LUCI-TryBot-Result: Go LUCI --- src/cmd/go/internal/load/test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/go/internal/load/test.go b/src/cmd/go/internal/load/test.go index d09ababfdd..3135805905 100644 --- a/src/cmd/go/internal/load/test.go +++ b/src/cmd/go/internal/load/test.go @@ -564,7 +564,7 @@ func recompileForTest(pmain, preal, ptest, pxtest *Package) *PackageError { } // isTestFunc tells whether fn has the type of a testing function. arg -// specifies the parameter type we look for: B, M or T. +// specifies the parameter type we look for: B, F, M or T. func isTestFunc(fn *ast.FuncDecl, arg string) bool { if fn.Type.Results != nil && len(fn.Type.Results.List) > 0 || fn.Type.Params.List == nil || @@ -579,7 +579,7 @@ func isTestFunc(fn *ast.FuncDecl, arg string) bool { // We can't easily check that the type is *testing.M // because we don't know how testing has been imported, // but at least check that it's *M or *something.M. - // Same applies for B and T. + // Same applies for B, F and T. if name, ok := ptr.X.(*ast.Ident); ok && name.Name == arg { return true } -- 2.48.1