From 661f3f15d5c96704a2fe9e91c6c40f73ff896606 Mon Sep 17 00:00:00 2001 From: Filippo Valsorda Date: Mon, 15 Mar 2021 23:10:21 +0100 Subject: [PATCH] net: fix BenchmarkWriteToReadFromUDP on Windows Using 0.0.0.0 for ListenUDP listens on all addresses. Calling LocalAddr on that Conn returns 0.0.0.0. Sending to 0.0.0.0 doesn't seem to work on Windows. See #22827. Change-Id: I4a48fbabe65a63e07600a65309977cec08a9c1e5 Reviewed-on: https://go-review.googlesource.com/c/go/+/301850 Run-TryBot: Filippo Valsorda TryBot-Result: Go Bot Reviewed-by: David Chase Trust: Filippo Valsorda --- src/net/udpsock_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net/udpsock_test.go b/src/net/udpsock_test.go index 8aa64baefe..b4000b5664 100644 --- a/src/net/udpsock_test.go +++ b/src/net/udpsock_test.go @@ -447,7 +447,7 @@ func TestUDPReadSizeError(t *testing.T) { } func BenchmarkWriteToReadFromUDP(b *testing.B) { - conn, err := ListenUDP("udp4", new(UDPAddr)) + conn, err := ListenUDP("udp4", &UDPAddr{IP: IPv4(127, 0, 0, 1)}) if err != nil { b.Fatal(err) } -- 2.50.0