From 66e8471391faa33aced2752f4c06a9fab444542b Mon Sep 17 00:00:00 2001 From: Rick Arnold Date: Fri, 9 Aug 2013 16:05:40 +1000 Subject: [PATCH] cmd/gc: make missing package error fatal No longer continue assuming package main. Fixes #4776. R=golang-dev, r CC=golang-dev https://golang.org/cl/12677043 --- src/cmd/gc/go.y | 3 +-- src/cmd/gc/y.tab.c | 3 +-- test/fixedbugs/issue4776.go | 10 ++++++++++ 3 files changed, 12 insertions(+), 4 deletions(-) create mode 100644 test/fixedbugs/issue4776.go diff --git a/src/cmd/gc/go.y b/src/cmd/gc/go.y index 4fcb8c0f05..7346b06b2a 100644 --- a/src/cmd/gc/go.y +++ b/src/cmd/gc/go.y @@ -136,8 +136,7 @@ package: { prevlineno = lineno; yyerror("package statement must be first"); - flusherrors(); - mkpackage("main"); + errorexit(); } | LPACKAGE sym ';' { diff --git a/src/cmd/gc/y.tab.c b/src/cmd/gc/y.tab.c index 39c0b12b64..eb11ef104c 100644 --- a/src/cmd/gc/y.tab.c +++ b/src/cmd/gc/y.tab.c @@ -2428,8 +2428,7 @@ yyreduce: { prevlineno = lineno; yyerror("package statement must be first"); - flusherrors(); - mkpackage("main"); + errorexit(); } break; diff --git a/test/fixedbugs/issue4776.go b/test/fixedbugs/issue4776.go new file mode 100644 index 0000000000..c38dc09b12 --- /dev/null +++ b/test/fixedbugs/issue4776.go @@ -0,0 +1,10 @@ +// errorcheck + +// Copyright 2013 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Issue 4776: missing package declaration error should be fatal. + +type MyInt int32 // ERROR "package statement must be first" + -- 2.48.1