From 67ce6af4567e6edb8b246494f7faa511485666ac Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Mon, 21 Nov 2016 22:30:14 +0000 Subject: [PATCH] cmd/dist: skip plugin tests on noopt builder for now Updates #17937 Change-Id: Ic822da1786a983b3b7bca21b68c3d5fc4bdfaee2 Reviewed-on: https://go-review.googlesource.com/33428 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: David Crawshaw --- src/cmd/dist/test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 03edbdfc19..508863f275 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -746,6 +746,14 @@ func (t *tester) supportedBuildmode(mode string) bool { } return false case "plugin": + if os.Getenv("GO_BUILDER_NAME") == "linux-amd64-noopt" { + // Skip the plugin tests on noopt. They're + // causing build failures potentially + // obscuring other issues. This is hopefully a + // temporary workaround. See golang.org/issue/17937. + return false + } + // linux-arm64 is missing because it causes the external linker // to crash, see https://golang.org/issue/17138 switch pair { -- 2.50.0