From 67f131485541f362c8e932cd254982a8ad2cfc09 Mon Sep 17 00:00:00 2001 From: Michael Anthony Knyszek Date: Tue, 29 Oct 2024 21:13:41 +0000 Subject: [PATCH] runtime: skip TestMemmoveOverflow with asan On a whim I decided to investigate the possibility of whether the flakiness on the asan builder was due to a concurrently executing test. Of the most recent failures there were a few candidates, and this test was one of them. After disabling each candidate one by one, we had a winner: this test causes other concurrently executing tests, running pure Go code, to spuriously fail. I do not know why yet, but this test doesn't seem like it would have incredibly high value for ASAN, and does funky things like MAP_FIXED in recently unmapped regions, so I think it's fine. For #70054. For #64257. Change-Id: Ib9a84d9b69812e76c390d99b00698710ee1ece1a Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-asan-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/623336 LUCI-TryBot-Result: Go LUCI Auto-Submit: Michael Knyszek Reviewed-by: Cherry Mui --- src/runtime/memmove_linux_amd64_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/runtime/memmove_linux_amd64_test.go b/src/runtime/memmove_linux_amd64_test.go index 5f900623be..c558811599 100644 --- a/src/runtime/memmove_linux_amd64_test.go +++ b/src/runtime/memmove_linux_amd64_test.go @@ -5,6 +5,7 @@ package runtime_test import ( + "internal/asan" "os" "syscall" "testing" @@ -14,6 +15,10 @@ import ( // TestMemmoveOverflow maps 3GB of memory and calls memmove on // the corresponding slice. func TestMemmoveOverflow(t *testing.T) { + if asan.Enabled { + t.Skip("appears to break asan and causes spurious failures") + } + t.Parallel() // Create a temporary file. tmp, err := os.CreateTemp("", "go-memmovetest") -- 2.48.1