From 6a5cfa8b63fcea71da941a60036ce3c6f22d8764 Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Thu, 8 Mar 2018 02:22:26 -0800 Subject: [PATCH] cmd/compile: remove two out-of-phase calls to walk All calls to walkstmt/walkexpr/etc should be rooted from funccompile, whereas transformclosure and fninit are called by main. Passes toolstash-check. Change-Id: Ic880e2d2d83af09618ce4daa8e7716f6b389e53e Reviewed-on: https://go-review.googlesource.com/99418 Run-TryBot: Matthew Dempsky TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/compile/internal/gc/closure.go | 1 - src/cmd/compile/internal/gc/init.go | 1 - 2 files changed, 2 deletions(-) diff --git a/src/cmd/compile/internal/gc/closure.go b/src/cmd/compile/internal/gc/closure.go index 1a79b7b149..6f90256090 100644 --- a/src/cmd/compile/internal/gc/closure.go +++ b/src/cmd/compile/internal/gc/closure.go @@ -417,7 +417,6 @@ func transformclosure(xfunc *Node) { if len(body) > 0 { typecheckslice(body, Etop) - walkstmtlist(body) xfunc.Func.Enter.Set(body) xfunc.Func.SetNeedctxt(true) } diff --git a/src/cmd/compile/internal/gc/init.go b/src/cmd/compile/internal/gc/init.go index 180cbcfda2..ea42664ba2 100644 --- a/src/cmd/compile/internal/gc/init.go +++ b/src/cmd/compile/internal/gc/init.go @@ -182,7 +182,6 @@ func fninit(n []*Node) { loop.Ninit.Set1(zero) loop = typecheck(loop, Etop) - loop = walkstmt(loop) r = append(r, loop) } -- 2.50.0