From 6a861010be9eed02d5285509cbaf3fb26d2c5041 Mon Sep 17 00:00:00 2001 From: Zxilly Date: Wed, 24 Jan 2024 21:27:41 +0000 Subject: [PATCH] debug/gosym: add detailed doc for text argument in NewLineTable Fixes #65232 Change-Id: I9ef76355cec4bea2d77811a69c61c1806c486be8 GitHub-Last-Rev: 9c617b65be9b01e9708e05a540316f98c8a0d165 GitHub-Pull-Request: golang/go#65263 Reviewed-on: https://go-review.googlesource.com/c/go/+/557957 LUCI-TryBot-Result: Go LUCI Reviewed-by: Cherry Mui Reviewed-by: Carlos Amedee --- src/debug/gosym/pclntab.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/debug/gosym/pclntab.go b/src/debug/gosym/pclntab.go index 6592932622..1d5498e037 100644 --- a/src/debug/gosym/pclntab.go +++ b/src/debug/gosym/pclntab.go @@ -148,7 +148,11 @@ func (t *LineTable) LineToPC(line int, maxpc uint64) uint64 { // NewLineTable returns a new PC/line table // corresponding to the encoded data. // Text must be the start address of the -// corresponding text segment. +// corresponding text segment, with the exact +// value stored in the 'runtime.text' symbol. +// This value may differ from the start +// address of the text segment if +// binary was built with cgo enabled. func NewLineTable(data []byte, text uint64) *LineTable { return &LineTable{Data: data, PC: text, Line: 0, funcNames: make(map[uint32]string), strings: make(map[uint32]string)} } -- 2.48.1