From 6c33f1d52efd4f70fb8cdb1c3b4ea1c8c579af2a Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Fri, 3 Jun 2022 12:38:39 -0700 Subject: [PATCH] [dev.unified] cmd/compile/internal/noder: rename exprName to exprGlobal More descriptive. Change-Id: I70a07adbe1d395da797fe15b54d2a1106f5f36a9 Reviewed-on: https://go-review.googlesource.com/c/go/+/410098 Reviewed-by: Cuong Manh Le TryBot-Result: Gopher Robot Reviewed-by: David Chase Run-TryBot: Matthew Dempsky --- src/cmd/compile/internal/noder/codes.go | 6 +++--- src/cmd/compile/internal/noder/reader.go | 2 +- src/cmd/compile/internal/noder/writer.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/cmd/compile/internal/noder/codes.go b/src/cmd/compile/internal/noder/codes.go index 8f54a07ca4..28991e7b9c 100644 --- a/src/cmd/compile/internal/noder/codes.go +++ b/src/cmd/compile/internal/noder/codes.go @@ -40,9 +40,9 @@ func (c codeExpr) Value() int { return int(c) } const ( exprNone codeExpr = iota exprConst - exprType // type expression - exprLocal // local variable - exprName // global variable or function + exprType // type expression + exprLocal // local variable + exprGlobal // global variable or function exprBlank exprCompLit exprFuncLit diff --git a/src/cmd/compile/internal/noder/reader.go b/src/cmd/compile/internal/noder/reader.go index 296cdd7d54..a231fe5d50 100644 --- a/src/cmd/compile/internal/noder/reader.go +++ b/src/cmd/compile/internal/noder/reader.go @@ -1562,7 +1562,7 @@ func (r *reader) expr() (res ir.Node) { case exprLocal: return typecheck.Expr(r.useLocal()) - case exprName: + case exprGlobal: // Callee instead of Expr allows builtins // TODO(mdempsky): Handle builtins directly in exprCall, like method calls? return typecheck.Callee(r.obj()) diff --git a/src/cmd/compile/internal/noder/writer.go b/src/cmd/compile/internal/noder/writer.go index b440ad3a1e..3bf6717117 100644 --- a/src/cmd/compile/internal/noder/writer.go +++ b/src/cmd/compile/internal/noder/writer.go @@ -1236,7 +1236,7 @@ func (w *writer) expr(expr syntax.Expr) { if obj != nil { if isGlobal(obj) { - w.Code(exprName) + w.Code(exprGlobal) w.obj(obj, targs) return } -- 2.48.1