From 6dde1fd792ba4ce41fcce50fc1c66b38666d6924 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Cl=C3=A9ment=20Chigot?= Date: Thu, 28 Feb 2019 09:13:56 +0100 Subject: [PATCH] runtime: disable TestGdbAutotmpTypes in short mode on aix/ppc64 TestGdbAutotmpTypes takes more than one minute due to gdb performances. Therefore, it must be skipped in short mode. Change-Id: I253ebce62264cc7367c9b0f6ce9c5088a9994641 Reviewed-on: https://go-review.googlesource.com/c/go/+/164339 Reviewed-by: Bryan C. Mills Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot --- src/runtime/runtime-gdb_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index d0f905e4d7..d47c7c2262 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -36,8 +36,6 @@ func checkGdbEnvironment(t *testing.T) { if runtime.GOARCH == "mips" { t.Skip("skipping gdb tests on linux/mips; see https://golang.org/issue/25939") } - case "aix": - t.Skip("gdb does not work on AIX; see https://golang.org/issue/28558") case "freebsd": t.Skip("skipping gdb tests on FreeBSD; see https://golang.org/issue/29508") } @@ -396,6 +394,10 @@ func TestGdbAutotmpTypes(t *testing.T) { t.Parallel() checkGdbVersion(t) + if runtime.GOOS == "aix" && testing.Short() { + t.Skip("TestGdbAutotmpTypes is too slow on aix/ppc64") + } + dir, err := ioutil.TempDir("", "go-build") if err != nil { t.Fatalf("failed to create temp directory: %v", err) -- 2.48.1