From 6fb8bf9d7940b2e2a90249e1894ad4e3d24fd3e7 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 12 Apr 2016 14:04:01 -0700 Subject: [PATCH] net: make two tests not parallel MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Running stress -p 1 go test -short std on a heavily loaded machine causes net timeouts every 15 or 20 runs. Making these tests not run in parallel helps. With this change, I haven’t seen a single failure in over 100 runs. Fixes #14986 Change-Id: Ibaa14869ce8d95b00266aee94d62d195927ede68 Reviewed-on: https://go-review.googlesource.com/21905 Run-TryBot: Josh Bleecher Snyder Reviewed-by: Brad Fitzpatrick --- src/net/timeout_test.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/net/timeout_test.go b/src/net/timeout_test.go index 3ea0ec1ebd..86010927b3 100644 --- a/src/net/timeout_test.go +++ b/src/net/timeout_test.go @@ -112,7 +112,6 @@ var dialTimeoutMaxDurationTests = []struct { } func TestDialTimeoutMaxDuration(t *testing.T) { - t.Parallel() if runtime.GOOS == "openbsd" { testenv.SkipFlaky(t, 15157) } @@ -315,8 +314,6 @@ var readTimeoutTests = []struct { } func TestReadTimeout(t *testing.T) { - t.Parallel() - switch runtime.GOOS { case "plan9": t.Skipf("not supported on %s", runtime.GOOS) -- 2.48.1