From 721f5ca4edc8073b777bd71df6801b237d72c332 Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 4 Feb 2025 17:04:26 +0100 Subject: [PATCH] runtime: adjust comments for auxv getAuxv github.com/cilium/ebpf no longer accesses getAuxv using linkname but now uses the golang.org/x/sys/unix.Auxv wrapper introduced in go.dev/cl/644295. Also adjust the list of users to include x/sys/unix. Updates #67839 Updates #67401 Change-Id: Ieee266360b22cc0bc4be8f740e0302afd7dbd14f Reviewed-on: https://go-review.googlesource.com/c/go/+/646535 Reviewed-by: Ian Lance Taylor Auto-Submit: Tobias Klauser LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov --- src/runtime/runtime.go | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/runtime/runtime.go b/src/runtime/runtime.go index e8e614815d..3afb6558b0 100644 --- a/src/runtime/runtime.go +++ b/src/runtime/runtime.go @@ -290,23 +290,15 @@ func setCrashFD(fd uintptr) uintptr { } // auxv is populated on relevant platforms but defined here for all platforms -// so x/sys/cpu can assume the getAuxv symbol exists without keeping its list -// of auxv-using GOOS build tags in sync. +// so x/sys/cpu and x/sys/unix can assume the getAuxv symbol exists without +// keeping its list of auxv-using GOOS build tags in sync. // // It contains an even number of elements, (tag, value) pairs. var auxv []uintptr -// golang.org/x/sys/cpu uses getAuxv via linkname. +// golang.org/x/sys/cpu and golang.org/x/sys/unix use getAuxv via linkname. // Do not remove or change the type signature. -// (See go.dev/issue/57336.) -// -// getAuxv should be an internal detail, -// but widely used packages access it using linkname. -// Notable members of the hall of shame include: -// - github.com/cilium/ebpf -// -// Do not remove or change the type signature. -// See go.dev/issue/67401. +// See go.dev/issue/57336 and go.dev/issue/67401. // //go:linkname getAuxv func getAuxv() []uintptr { return auxv } -- 2.51.0