From 735cf529833c3600a9518505977c2a25f32bb901 Mon Sep 17 00:00:00 2001 From: ChaiShushan Date: Thu, 11 Jul 2013 15:55:08 -0400 Subject: [PATCH] net/rpc: fix a test bug R=golang-dev, rsc CC=golang-dev https://golang.org/cl/10855043 --- src/pkg/net/rpc/server_test.go | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/pkg/net/rpc/server_test.go b/src/pkg/net/rpc/server_test.go index b64228111b..0631acdf94 100644 --- a/src/pkg/net/rpc/server_test.go +++ b/src/pkg/net/rpc/server_test.go @@ -99,11 +99,12 @@ func startNewServer() { newServer = NewServer() newServer.Register(new(Arith)) newServer.RegisterName("net.rpc.Arith", new(Arith)) + newServer.RegisterName("newServer.Arith", new(Arith)) var l net.Listener l, newServerAddr = listenTCP() log.Println("NewServer test RPC server listening on", newServerAddr) - go Accept(l) + go newServer.Accept(l) newServer.HandleHTTP(newHttpPath, "/bar") httpOnce.Do(startHttpServer) @@ -120,6 +121,7 @@ func TestRPC(t *testing.T) { testRPC(t, serverAddr) newOnce.Do(startNewServer) testRPC(t, newServerAddr) + testNewServerRPC(t, newServerAddr) } func testRPC(t *testing.T, addr string) { @@ -249,6 +251,25 @@ func testRPC(t *testing.T, addr string) { } } +func testNewServerRPC(t *testing.T, addr string) { + client, err := Dial("tcp", addr) + if err != nil { + t.Fatal("dialing", err) + } + defer client.Close() + + // Synchronous calls + args := &Args{7, 8} + reply := new(Reply) + err = client.Call("newServer.Arith.Add", args, reply) + if err != nil { + t.Errorf("Add: expected no error but got string %q", err.Error()) + } + if reply.C != args.A+args.B { + t.Errorf("Add: expected %d got %d", reply.C, args.A+args.B) + } +} + func TestHTTP(t *testing.T) { once.Do(startServer) testHTTPRPC(t, "") -- 2.48.1