From 748e5db96d8412d2142afb15c9a3da62f410d45a Mon Sep 17 00:00:00 2001 From: David du Colombier <0intro@gmail.com> Date: Thu, 24 Jul 2014 23:18:54 +0200 Subject: [PATCH] test/run: always set goos and goarch Following CL 68150047, the goos and goarch variables are not currently set when the GOOS and GOARCH environment variables are not set. This made the content of the build tag to be ignored in this case. This CL sets goos and goarch to runtime.GOOS and runtime.GOARCH when the GOOS and GOARCH environments variables are not set. LGTM=aram, bradfitz R=golang-codereviews, aram, gobot, rsc, dave, bradfitz CC=golang-codereviews, rsc https://golang.org/cl/112490043 --- test/run.go | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/test/run.go b/test/run.go index a8d4baa3ac..a8a6dedb23 100644 --- a/test/run.go +++ b/test/run.go @@ -71,8 +71,9 @@ const maxTests = 5000 func main() { flag.Parse() - goos = os.Getenv("GOOS") - goarch = os.Getenv("GOARCH") + goos = getenv("GOOS", runtime.GOOS) + goarch = getenv("GOARCH", runtime.GOARCH) + findExecCmd() // Disable parallelism if printing or if using a simulator. @@ -972,3 +973,11 @@ func envForDir(dir string) []string { env = append(env, "PWD="+dir) return env } + +func getenv(key, def string) string { + value := os.Getenv(key) + if value != "" { + return value + } + return def +} -- 2.48.1