From 75c1381176e98357b01a67af7e9dbaf68de7fdff Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 23 Nov 2016 01:43:33 +0000 Subject: [PATCH] cmd/gofmt: don't call Chmod on windows Fixes #18026 Change-Id: Id510f427ceffb2441c3d6f5bb5c93244e46c6497 Reviewed-on: https://go-review.googlesource.com/33477 TryBot-Result: Gobot Gobot Run-TryBot: Brad Fitzpatrick Reviewed-by: Alex Brainman --- src/cmd/gofmt/gofmt.go | 15 ++++++++++----- src/cmd/gofmt/gofmt_test.go | 13 +++++++++++++ 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/src/cmd/gofmt/gofmt.go b/src/cmd/gofmt/gofmt.go index 88ee75f52d..e1ef0ddb83 100644 --- a/src/cmd/gofmt/gofmt.go +++ b/src/cmd/gofmt/gofmt.go @@ -18,6 +18,7 @@ import ( "os" "os/exec" "path/filepath" + "runtime" "runtime/pprof" "strings" ) @@ -252,6 +253,8 @@ func diff(b1, b2 []byte) (data []byte, err error) { } +const chmodSupported = runtime.GOOS != "windows" + // backupFile writes data to a new file named filename with permissions perm, // with