From 7711bad100df2cbf744b14dfb587d605738e3de4 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Mon, 20 Apr 2020 10:55:02 +0700 Subject: [PATCH] cmd/compile: remove nil check for p in isReflectPkg CL 228859 refactored detecting reflect package logic in to isReflectPkg function. The function has un-necessary nil check for p, so remove that check. Passes toolstash-check. Change-Id: I2f3f1ac967fe8d176dda3f3b4698ded08602e2fa Reviewed-on: https://go-review.googlesource.com/c/go/+/228861 Run-TryBot: Cuong Manh Le TryBot-Result: Gobot Gobot Reviewed-by: Matthew Dempsky --- src/cmd/compile/internal/gc/go.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/cmd/compile/internal/gc/go.go b/src/cmd/compile/internal/gc/go.go index 758c90931f..9079ce2afc 100644 --- a/src/cmd/compile/internal/gc/go.go +++ b/src/cmd/compile/internal/gc/go.go @@ -47,10 +47,6 @@ func isRuntimePkg(p *types.Pkg) bool { // isReflectPkg reports whether p is package reflect. func isReflectPkg(p *types.Pkg) bool { - // TODO(cuonglm): how to get rid this check. - if p == nil { - return false - } if p == localpkg { return myimportpath == "reflect" } -- 2.50.0