From 7778b5ab5a2215668ad1ad4d174d58b3363c9de8 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Tue, 5 Mar 2019 17:01:19 -0500 Subject: [PATCH] cmd/go: clear GOPROXY in TestGoGetInsecure TestGoGetInsecure verifies that 'go get -insecure' can fetch a particular package. However, the GOPROXY protocol does not provide a means for proxies to indicate packages as insecure; thus, proxies cannot safely serve those packages. Updates #30571 Change-Id: I447776dff98bd8ee6eb5055b897b9c7d293e3423 Reviewed-on: https://go-review.googlesource.com/c/go/+/165745 Run-TryBot: Bryan C. Mills Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/cmd/go/go_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index 9ba52e609e..c6fb046b32 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -3670,6 +3670,7 @@ func TestGoGetInsecure(t *testing.T) { tg.tempFile("go.mod", "module m") tg.cd(tg.path(".")) tg.setenv("GO111MODULE", "on") + tg.setenv("GO111PROXY", "") } else { tg.setenv("GOPATH", tg.path(".")) tg.setenv("GO111MODULE", "off") -- 2.50.0