From 780fa2426073035459b8a5d8e317f47864132ce4 Mon Sep 17 00:00:00 2001 From: David Chase Date: Mon, 9 Jan 2023 13:36:36 -0500 Subject: [PATCH] net: add testing.Short Skip to test affected by local network configuration If the local network mangles invalid DNS queries, that is not a Go problem. Change-Id: I54db392532eed988bca81b70a98cd6d11766af89 Reviewed-on: https://go-review.googlesource.com/c/go/+/461275 Run-TryBot: David Chase Reviewed-by: Damien Neil TryBot-Result: Gopher Robot --- src/net/dnsclient_unix_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/net/dnsclient_unix_test.go b/src/net/dnsclient_unix_test.go index 3ba19eb813..990b3f99ce 100644 --- a/src/net/dnsclient_unix_test.go +++ b/src/net/dnsclient_unix_test.go @@ -2199,6 +2199,9 @@ var goLookupIPCNAMEOrderDNSFilesModeTests = []struct { } func TestGoLookupIPCNAMEOrderHostsAliasesDNSFilesMode(t *testing.T) { + if testing.Short() { + t.Skip("Makes assumptions about local networks and (re)naming that aren't always true") + } defer func(orig string) { testHookHostsPath = orig }(testHookHostsPath) testHookHostsPath = "testdata/aliases" mode := hostLookupDNSFiles -- 2.50.0