From 78175474c4a93c2b18516d2127a160b83926c143 Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 9 Apr 2019 08:35:36 +0200 Subject: [PATCH] strings: use Go style character range comparison in ToUpper/ToLower As noted by Brad in CL 170954 for package bytes. Change-Id: I2772a356299e54ba5b7884d537e6649039adb9be Reviewed-on: https://go-review.googlesource.com/c/go/+/171198 Run-TryBot: Tobias Klauser TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/strings/strings.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/strings/strings.go b/src/strings/strings.go index 5a126a7a19..1805a14bd2 100644 --- a/src/strings/strings.go +++ b/src/strings/strings.go @@ -559,7 +559,7 @@ func ToUpper(s string) string { isASCII = false break } - hasLower = hasLower || (c >= 'a' && c <= 'z') + hasLower = hasLower || ('a' <= c && c <= 'z') } if isASCII { // optimize for ASCII-only strings. @@ -570,7 +570,7 @@ func ToUpper(s string) string { b.Grow(len(s)) for i := 0; i < len(s); i++ { c := s[i] - if c >= 'a' && c <= 'z' { + if 'a' <= c && c <= 'z' { c -= 'a' - 'A' } b.WriteByte(c) @@ -589,7 +589,7 @@ func ToLower(s string) string { isASCII = false break } - hasUpper = hasUpper || (c >= 'A' && c <= 'Z') + hasUpper = hasUpper || ('A' <= c && c <= 'Z') } if isASCII { // optimize for ASCII-only strings. @@ -600,7 +600,7 @@ func ToLower(s string) string { b.Grow(len(s)) for i := 0; i < len(s); i++ { c := s[i] - if c >= 'A' && c <= 'Z' { + if 'A' <= c && c <= 'Z' { c += 'a' - 'A' } b.WriteByte(c) -- 2.48.1