From 78e5288b5c720d996ea5132f1fa0348968ff0513 Mon Sep 17 00:00:00 2001 From: Andrew Medvedev Date: Sat, 21 Sep 2019 12:47:34 +0000 Subject: [PATCH] strings, bytes: clarify usage of EqualFolds This clarifies meaning of "case folding" Unicode equality with more familiar "case insensitive" wording. For case folding properties see ftp://ftp.unicode.org/Public/UNIDATA/CaseFolding.txt. Fixes #33447 Change-Id: I6ee85ab398679bf2a0b7d18693985ff0979d6c5a GitHub-Last-Rev: accc9159330c61e046d77f77beac62b38bf72c19 GitHub-Pull-Request: golang/go#34434 Reviewed-on: https://go-review.googlesource.com/c/go/+/196717 Reviewed-by: Rob Pike --- src/bytes/bytes.go | 3 ++- src/strings/strings.go | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/bytes/bytes.go b/src/bytes/bytes.go index eb13212384..e872cc2050 100644 --- a/src/bytes/bytes.go +++ b/src/bytes/bytes.go @@ -935,7 +935,8 @@ func ReplaceAll(s, old, new []byte) []byte { } // EqualFold reports whether s and t, interpreted as UTF-8 strings, -// are equal under Unicode case-folding. +// are equal under Unicode case-folding, which is a more general +// form of case-insensitivity. func EqualFold(s, t []byte) bool { for len(s) != 0 && len(t) != 0 { // Extract first rune from each. diff --git a/src/strings/strings.go b/src/strings/strings.go index cee315ce9e..869cdcdcef 100644 --- a/src/strings/strings.go +++ b/src/strings/strings.go @@ -969,7 +969,8 @@ func ReplaceAll(s, old, new string) string { } // EqualFold reports whether s and t, interpreted as UTF-8 strings, -// are equal under Unicode case-folding. +// are equal under Unicode case-folding, which is a more general +// form of case-insensitivity. func EqualFold(s, t string) bool { for s != "" && t != "" { // Extract first rune from each string. -- 2.50.0