From 792f9c9a954c1fab92e5244f18072c4b2df4c301 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Fri, 14 Jul 2017 15:52:41 +0000 Subject: [PATCH] net/http: clarify Handler panic behavior across HTTP versions Updates #18997 Change-Id: Ib1961a4c26b42f99b98b255beb7e2a74b632e0c1 Reviewed-on: https://go-review.googlesource.com/48551 Reviewed-by: Joe Shaw Reviewed-by: Tom Bergan --- src/net/http/server.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/net/http/server.go b/src/net/http/server.go index 5447e5f89a..736c9b83a4 100644 --- a/src/net/http/server.go +++ b/src/net/http/server.go @@ -75,9 +75,10 @@ var ( // If ServeHTTP panics, the server (the caller of ServeHTTP) assumes // that the effect of the panic was isolated to the active request. // It recovers the panic, logs a stack trace to the server error log, -// and hangs up the connection. To abort a handler so the client sees -// an interrupted response but the server doesn't log an error, panic -// with the value ErrAbortHandler. +// and either closes the network connection or sends an HTTP/2 +// RST_STREAM, depending on the HTTP protocol. To abort a handler so +// the client sees an interrupted response but the server doesn't log +// an error, panic with the value ErrAbortHandler. type Handler interface { ServeHTTP(ResponseWriter, *Request) } -- 2.50.0