From 7939c43748932c0caf1a1538410eb70fcd5a705f Mon Sep 17 00:00:00 2001 From: Cherry Zhang Date: Tue, 31 Mar 2020 19:13:39 -0400 Subject: [PATCH] runtime: generate dummy duffcopy Although duffcopy is not used on PPC64, duff_ppc64x.s and mkduff.go don't match. Make it so. Fixes #38188. Change-Id: Ic6c08e335795ea407880efd449f4229696af7744 Reviewed-on: https://go-review.googlesource.com/c/go/+/226719 Run-TryBot: Cherry Zhang Reviewed-by: Josh Bleecher Snyder TryBot-Result: Gobot Gobot --- src/runtime/duff_ppc64x.s | 6 ++---- src/runtime/mkduff.go | 4 +++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/runtime/duff_ppc64x.s b/src/runtime/duff_ppc64x.s index 0c62d0afe9..d6b89ba940 100644 --- a/src/runtime/duff_ppc64x.s +++ b/src/runtime/duff_ppc64x.s @@ -137,7 +137,5 @@ TEXT runtime·duffzero(SB), NOSPLIT|NOFRAME, $0-0 MOVDU R0, 8(R3) RET -// TODO: Implement runtime·duffcopy. -TEXT runtime·duffcopy(SB),NOSPLIT|NOFRAME,$0-0 - MOVD R0, 0(R0) - RET +TEXT runtime·duffcopy(SB), NOSPLIT|NOFRAME, $0-0 + UNDEF diff --git a/src/runtime/mkduff.go b/src/runtime/mkduff.go index 6ac5e7da44..6c7a4cf8dc 100644 --- a/src/runtime/mkduff.go +++ b/src/runtime/mkduff.go @@ -194,7 +194,9 @@ func zeroPPC64x(w io.Writer) { } func copyPPC64x(w io.Writer) { - fmt.Fprintln(w, "// TODO: Implement runtime·duffcopy.") + // duffcopy is not used on PPC64. + fmt.Fprintln(w, "TEXT runtime·duffcopy(SB), NOSPLIT|NOFRAME, $0-0") + fmt.Fprintln(w, "\tUNDEF") } func tagsMIPS64x(w io.Writer) { -- 2.51.0