From 79e01ab7e6ffbc4c07515dcfef04d1f0a5ca533d Mon Sep 17 00:00:00 2001 From: qmuntal Date: Fri, 10 Feb 2023 10:36:16 +0100 Subject: [PATCH] cmd/dist: remove windows-amd64-2008 code path `windows-amd64-2008` builder does no longer exist on go1.20, so it is safe to remove conditions checking for that name. Updates #57003 Closes #56904 Change-Id: I941ccc64cda0af3b9356996c4b581700afa81987 Reviewed-on: https://go-review.googlesource.com/c/go/+/467175 Run-TryBot: Quim Muntal Reviewed-by: Bryan Mills TryBot-Result: Gopher Robot Reviewed-by: Than McIntosh --- src/cmd/dist/test.go | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 35a9b50a70..4395d3a33b 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -1568,13 +1568,6 @@ func (t *tester) registerRaceTests() { // t.registerTest("race:misc/cgo/test", hdr, &goTest{dir: "../misc/cgo/test", race: true, env: []string{"GOTRACEBACK=2"}}) } if t.extLink() { - var oldWindows rtPreFunc - if strings.HasPrefix(os.Getenv("GO_BUILDER_NAME"), "windows-amd64-2008") { - oldWindows.pre = func(*distTest) bool { - fmt.Println("skipping -race with external linkage on older windows builder, see https://github.com/golang/go/issues/56904 for details") - return false - } - } // Test with external linking; see issue 9133. t.registerTest("race:external", hdr, &goTest{ @@ -1582,7 +1575,7 @@ func (t *tester) registerRaceTests() { ldflags: "-linkmode=external", runTests: "TestParse|TestEcho|TestStdinCloseRace", pkgs: []string{"flag", "os/exec"}, - }, oldWindows) + }) } } -- 2.50.0