From 7a86ef2ad88af19642d7feaebacffd0260114d2a Mon Sep 17 00:00:00 2001 From: Sasha Melentyev Date: Fri, 2 Sep 2022 07:54:43 +0000 Subject: [PATCH] all: use strings.Builder instead of bytes.Buffer MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Change-Id: I6d7213d29ade591b8366d5640833bd5a20474165 GitHub-Last-Rev: 94195832873fe6764d45ffdd6efa1ca49e57a743 GitHub-Pull-Request: golang/go#54834 Reviewed-on: https://go-review.googlesource.com/c/go/+/427814 TryBot-Result: Gopher Robot Run-TryBot: Ian Lance Taylor Auto-Submit: Ian Lance Taylor Reviewed-by: hopehook Run-TryBot: Daniel Martí Reviewed-by: Heschi Kreinick Reviewed-by: Ian Lance Taylor Reviewed-by: Daniel Martí --- src/cmd/go/internal/str/str.go | 8 ++++---- src/go/internal/gccgoimporter/parser.go | 9 ++++----- src/net/mail/message.go | 14 +++++++------- 3 files changed, 15 insertions(+), 16 deletions(-) diff --git a/src/cmd/go/internal/str/str.go b/src/cmd/go/internal/str/str.go index 975869d760..af7c699972 100644 --- a/src/cmd/go/internal/str/str.go +++ b/src/cmd/go/internal/str/str.go @@ -6,8 +6,8 @@ package str import ( - "bytes" "fmt" + "strings" "unicode" "unicode/utf8" ) @@ -49,7 +49,7 @@ func ToFold(s string) string { return s Slow: - var buf bytes.Buffer + var b strings.Builder for _, r := range s { // SimpleFold(x) cycles to the next equivalent rune > x // or wraps around to smaller values. Iterate until it wraps, @@ -65,9 +65,9 @@ Slow: if 'A' <= r && r <= 'Z' { r += 'a' - 'A' } - buf.WriteRune(r) + b.WriteRune(r) } - return buf.String() + return b.String() } // FoldDup reports a pair of strings from the list that are diff --git a/src/go/internal/gccgoimporter/parser.go b/src/go/internal/gccgoimporter/parser.go index 536083ae08..de9df0bbfb 100644 --- a/src/go/internal/gccgoimporter/parser.go +++ b/src/go/internal/gccgoimporter/parser.go @@ -5,7 +5,6 @@ package gccgoimporter import ( - "bytes" "errors" "fmt" "go/constant" @@ -129,16 +128,16 @@ func (p *parser) parseUnquotedString() string { if p.tok == scanner.EOF { p.error("unexpected EOF") } - var buf bytes.Buffer - buf.WriteString(p.scanner.TokenText()) + var b strings.Builder + b.WriteString(p.scanner.TokenText()) // This loop needs to examine each character before deciding whether to consume it. If we see a semicolon, // we need to let it be consumed by p.next(). for ch := p.scanner.Peek(); ch != '\n' && ch != ';' && ch != scanner.EOF && p.scanner.Whitespace&(1<