From 7abc8a2e3370bd013d9aa12b5d443e21537dfb26 Mon Sep 17 00:00:00 2001 From: Alexander Scheel Date: Thu, 3 Nov 2022 13:09:31 +0000 Subject: [PATCH] crypto/x509: switch test to ParseRevocationList In following with Roland's TODO, switch TestDisableSHA1ForCertOnly to ParseRevocationList(...) over ParseCRL(...). Change-Id: I8cdaf04ad0a1c8b94303415ae41933657067041e GitHub-Last-Rev: bb2ef760e4fdd8c0c9228004674d4e1f581c4271 GitHub-Pull-Request: golang/go#56541 Reviewed-on: https://go-review.googlesource.com/c/go/+/447036 Reviewed-by: Roland Shoemaker Run-TryBot: Roland Shoemaker TryBot-Result: Gopher Robot Reviewed-by: Matthew Dempsky Auto-Submit: Roland Shoemaker --- src/crypto/x509/x509_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/crypto/x509/x509_test.go b/src/crypto/x509/x509_test.go index 44441d45d4..0ba6d3e9fa 100644 --- a/src/crypto/x509/x509_test.go +++ b/src/crypto/x509/x509_test.go @@ -3553,13 +3553,12 @@ func TestDisableSHA1ForCertOnly(t *testing.T) { if err != nil { t.Fatalf("failed to generate test CRL: %s", err) } - // TODO(rolandshoemaker): this should be ParseRevocationList once it lands - crl, err := ParseCRL(crlDER) + crl, err := ParseRevocationList(crlDER) if err != nil { t.Fatalf("failed to parse test CRL: %s", err) } - if err = cert.CheckCRLSignature(crl); err != nil { + if err = crl.CheckSignatureFrom(cert); err != nil { t.Errorf("unexpected error: %s", err) } -- 2.50.0