From 7adafc985aa6bf5f66de1b6e9ff9d553d8dd183b Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" Date: Mon, 25 Nov 2019 19:23:44 +0100 Subject: [PATCH] cmd/go: prefix calls to Windows rmdir with cmd.exe rmdir is a built-in of cmd.exe. It's also an alias in powershell.exe. We want always the cmd.exe on, so specify it explicitly. Fixes #35813 Change-Id: I89723e993ee26a20b42d03b8a725ff10ccf30505 Reviewed-on: https://go-review.googlesource.com/c/go/+/208639 Run-TryBot: Jason A. Donenfeld Reviewed-by: Bryan C. Mills TryBot-Result: Gobot Gobot --- src/cmd/go/testdata/script/mod_cache_rw.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/go/testdata/script/mod_cache_rw.txt b/src/cmd/go/testdata/script/mod_cache_rw.txt index b4a3a456e8..a5410764bc 100644 --- a/src/cmd/go/testdata/script/mod_cache_rw.txt +++ b/src/cmd/go/testdata/script/mod_cache_rw.txt @@ -19,8 +19,8 @@ cp $WORK/extraneous.txt $GOPATH/pkg/mod/rsc.io/quote@v1.5.2/extraneous_file.go # should be able to remove the module cache if the '-rf' flags are set. [!windows] [exec:rm] exec rm -rf $GOPATH/pkg/mod [!windows] [!exec:rm] go clean -modcache -[windows] [exec:rmdir] exec rmdir /s /q $GOPATH\pkg\mod -[windows] [!exec:rmdir] go clean -modcache +[windows] [exec:cmd.exe] exec cmd.exe /c rmdir /s /q $GOPATH\pkg\mod +[windows] [!exec:cmd.exe] go clean -modcache ! exists $GOPATH/pkg/mod # The directories in the module cache should by default be unwritable, -- 2.50.0