From 7ed6073da0bb62b65984ffd2bba320334d928bd5 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Sat, 10 Sep 2022 02:36:59 +0700 Subject: [PATCH] cmd/compile: update bottomUpVisitor.visit comments Change-Id: I83a62b15c5946cfe61afc53c2c528aa3a62f815e Reviewed-on: https://go-review.googlesource.com/c/go/+/429975 Reviewed-by: Matthew Dempsky Reviewed-by: Cherry Mui TryBot-Result: Gopher Robot Auto-Submit: Cuong Manh Le Run-TryBot: Cuong Manh Le --- src/cmd/compile/internal/ir/scc.go | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/cmd/compile/internal/ir/scc.go b/src/cmd/compile/internal/ir/scc.go index a42951c1dd..b222939a1e 100644 --- a/src/cmd/compile/internal/ir/scc.go +++ b/src/cmd/compile/internal/ir/scc.go @@ -103,16 +103,13 @@ func (v *bottomUpVisitor) visit(n *Func) uint32 { if (min == id || min == id+1) && !n.IsHiddenClosure() { // This node is the root of a strongly connected component. - // The original min passed to visitcodelist was v.nodeID[n]+1. - // If visitcodelist found its way back to v.nodeID[n], then this - // block is a set of mutually recursive functions. - // Otherwise it's just a lone function that does not recurse. + // The original min was id+1. If the bottomUpVisitor found its way + // back to id, then this block is a set of mutually recursive functions. + // Otherwise, it's just a lone function that does not recurse. recursive := min == id - // Remove connected component from stack. - // Mark walkgen so that future visits return a large number - // so as not to affect the caller's min. - + // Remove connected component from stack and mark v.nodeID so that future + // visits return a large number, which will not affect the caller's min. var i int for i = len(v.stack) - 1; i >= 0; i-- { x := v.stack[i] @@ -122,7 +119,7 @@ func (v *bottomUpVisitor) visit(n *Func) uint32 { } } block := v.stack[i:] - // Run escape analysis on this set of functions. + // Call analyze on this set of functions. v.stack = v.stack[:i] v.analyze(block, recursive) } -- 2.50.0