From 804850d87b7581daa54c0aa4b1972e2d08b4b8f7 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 12 May 2023 15:19:23 -0400 Subject: [PATCH] cmd/cgo/internal/testcarchive: build on all platforms This test package uses syscall.SIGSEGV and syscall.SIGPIPE, which are defined on most, but not all platforms. Normally this test runs as part of dist test, which only registers this test on platforms that support c-archive build mode, which includes all platforms that define these signals. But this doesn't help if you're just trying to type check everything in cmd. Add build constraints so that this package type checks on all platforms. Fixes #60164. Updates #37486. Change-Id: Id3f9ad4cc9f80146de16aedcf85d108a77215ae6 Reviewed-on: https://go-review.googlesource.com/c/go/+/494659 Reviewed-by: Bryan Mills Run-TryBot: Austin Clements Auto-Submit: Austin Clements TryBot-Result: Gopher Robot --- src/cmd/cgo/internal/testcarchive/carchive_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cmd/cgo/internal/testcarchive/carchive_test.go b/src/cmd/cgo/internal/testcarchive/carchive_test.go index 7830edf774..51a73ee77f 100644 --- a/src/cmd/cgo/internal/testcarchive/carchive_test.go +++ b/src/cmd/cgo/internal/testcarchive/carchive_test.go @@ -2,6 +2,11 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. +// This test uses various syscall.SIG* constants that are defined on Unix +// platforms and Windows. + +//go:build unix || windows + package carchive_test import ( -- 2.50.0