From 81ed9ca1d411f0bd8738ea60b3a8045446ad85fc Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Tue, 27 Jun 2017 16:21:48 +0000 Subject: [PATCH] cmd/go: skip broken TestExecutableGOROOT/RelocatedExe Test just doesn't work. Updates #20284 Change-Id: I31c3f771e68dcdc471767594a1467e19fbf5fe88 Reviewed-on: https://go-review.googlesource.com/46830 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Andrew Bonventre --- src/cmd/go/go_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index d047596369..f36432cf34 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -4072,6 +4072,8 @@ func TestExecutableGOROOT(t *testing.T) { newRoot := tg.path("new") t.Run("RelocatedExe", func(t *testing.T) { + t.Skip("TODO: skipping known broken test; see golang.org/issue/20284") + // Should fall back to default location in binary. // No way to dig out other than look at source code. data, err := ioutil.ReadFile("../../runtime/internal/sys/zversion.go") -- 2.50.0