From 821e3f7d85e4f05d83f5f93e99bf299a6bfc9034 Mon Sep 17 00:00:00 2001 From: Alex Brainman Date: Fri, 10 Nov 2017 10:26:05 +1100 Subject: [PATCH] cmd/go: close unintentionally left open file cmd/go/internal/work.Builder.updateBuildID left a file opened. But opened files cannot be deleted on Windows, so cmd/go just leaves these files in %TMP% directory. Close the file so deletion can succeed. Fixes #22650 Change-Id: Ia3ea62f6ec7208d73972eae2e17fb4a766407914 Reviewed-on: https://go-review.googlesource.com/76810 Reviewed-by: Dave Cheney Run-TryBot: Alex Brainman TryBot-Result: Gobot Gobot --- src/cmd/go/internal/work/buildid.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cmd/go/internal/work/buildid.go b/src/cmd/go/internal/work/buildid.go index d7cc7a263b..caf6195abb 100644 --- a/src/cmd/go/internal/work/buildid.go +++ b/src/cmd/go/internal/work/buildid.go @@ -448,6 +448,7 @@ func (b *Builder) updateBuildID(a *Action, target string, rewrite bool) error { r, err := os.Open(target) if err == nil { c.Put(a.actionID, r) + r.Close() } } -- 2.48.1