From 87d59bcdc354b035e17a1dadbfc4883bbcac5bf8 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Mon, 5 Oct 2020 16:00:08 -0700 Subject: [PATCH] doc: mention Trust+1 in contribution guide For #40699 Change-Id: If753a073488880433ae3319dcf2a2dfaa887fd0e Reviewed-on: https://go-review.googlesource.com/c/go/+/259737 Trust: Ian Lance Taylor Trust: Tobias Klauser Reviewed-by: Emmanuel Odeke Reviewed-by: Russ Cox --- doc/contribute.html | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/contribute.html b/doc/contribute.html index 09d43313ff..f297477fe0 100644 --- a/doc/contribute.html +++ b/doc/contribute.html @@ -947,10 +947,18 @@ The Gerrit voting system involves an integer in the range -2 to +2: +

+At least two maintainers must approve of the change, and at least one +of those maintainers must +2 the change. +The second maintainer may cast a vote of Trust+1, meaning that the +change looks basically OK, but that the maintainer hasn't done the +detailed review required for a +2 vote. +

+

Submitting an approved change

-After the code has been +2'ed, an approver will +After the code has been +2'ed and Trust+1'ed, an approver will apply it to the master branch using the Gerrit user interface. This is called "submitting the change".

-- 2.48.1