From 88cf932e98db8fe014399e05320128d76183f3fa Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Tue, 29 Nov 2016 02:45:11 -0800 Subject: [PATCH] cmd/compile: improve assignment count mismatch error message Given the following test cases: $ cat left_too_many.go package main func main() { a, err := make([]int, 1) } $ cat right_too_many.go package main func main() { a := "foo", "bar" } Before this change, the error messages are: ./left_too_many.go:4: assignment count mismatch: 2 = 1 ./right_too_many.go:4: assignment count mismatch: 1 = 2 After this change, the error messages are: ./left_too_many.go:4: assignment count mismatch: want 2 values, got 1 ./right_too_many.go:4: assignment count mismatch: want 1 values, got 2 Change-Id: I9ad346f122406bc9a785bf690ed7b3de76a422da Reviewed-on: https://go-review.googlesource.com/33616 Reviewed-by: Robert Griesemer Run-TryBot: Robert Griesemer TryBot-Result: Gobot Gobot --- src/cmd/compile/internal/gc/typecheck.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/compile/internal/gc/typecheck.go b/src/cmd/compile/internal/gc/typecheck.go index 0c0782d40f..8299e49a34 100644 --- a/src/cmd/compile/internal/gc/typecheck.go +++ b/src/cmd/compile/internal/gc/typecheck.go @@ -3429,7 +3429,7 @@ func typecheckas2(n *Node) { } mismatch: - yyerror("assignment count mismatch: %d = %d", cl, cr) + yyerror("assignment count mismatch: want %d values, got %d", cl, cr) // second half of dance out: -- 2.48.1