From 8bbd8294d01b66bf47514dee94d3c4341566e357 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Thu, 19 Nov 2020 13:26:51 -0500 Subject: [PATCH] cmd/go/internal/work: remove a redundant call to modload.LoadedModules The modload.EditBuildList call added in CL 270980 already ensures that installMod does not require a newer version of itself, so the condition that this loop is checking for is redundant. (I had meant for this change to be included in CL 270980, but apparently somehow reverted it prior to mailing.) For #36460 Change-Id: I4dd746b927f7012d950187cac9c510cd6fec8fd9 Reviewed-on: https://go-review.googlesource.com/c/go/+/271646 Run-TryBot: Bryan C. Mills TryBot-Result: Go Bot Reviewed-by: Jay Conrod Trust: Bryan C. Mills --- src/cmd/go/internal/work/build.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/cmd/go/internal/work/build.go b/src/cmd/go/internal/work/build.go index e0aa691659..ca88f0efa1 100644 --- a/src/cmd/go/internal/work/build.go +++ b/src/cmd/go/internal/work/build.go @@ -840,11 +840,6 @@ func installOutsideModule(ctx context.Context, args []string) { } // Check that named packages are all provided by the same module. - for _, mod := range modload.LoadedModules() { - if mod.Path == installMod.Path && mod.Version != installMod.Version { - base.Fatalf("go install: %s: module requires a higher version of itself (%s)", installMod, mod.Version) - } - } for _, pkg := range mainPkgs { if pkg.Module == nil { // Packages in std, cmd, and their vendored dependencies -- 2.48.1