From 8bc32785b99eccf27cede237c974172988bb0c81 Mon Sep 17 00:00:00 2001 From: Dave Cheney Date: Fri, 17 Jan 2014 09:49:38 +1100 Subject: [PATCH] net: skip TestDualStackTCPListener in short mode Update #5001 This test is flakey on linux servers and fails otherwise good builds. Mikio has some proposals to fix the test, but they require additional plumbing. In the meantime, disable this test in -short mode so it will run during the full net test suite, but not during builder ci. R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/53410043 --- src/pkg/net/unicast_posix_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/pkg/net/unicast_posix_test.go b/src/pkg/net/unicast_posix_test.go index 5deb8f47c6..452ac92542 100644 --- a/src/pkg/net/unicast_posix_test.go +++ b/src/pkg/net/unicast_posix_test.go @@ -166,9 +166,12 @@ var dualStackListenerTests = []struct { } // TestDualStackTCPListener tests both single and double listen -// to a test listener with various address families, differnet +// to a test listener with various address families, different // listening address and same port. func TestDualStackTCPListener(t *testing.T) { + if testing.Short() { + t.Skip("skipping in -short mode, see issue 5001") + } switch runtime.GOOS { case "plan9": t.Skipf("skipping test on %q", runtime.GOOS) @@ -178,7 +181,7 @@ func TestDualStackTCPListener(t *testing.T) { } for _, tt := range dualStackListenerTests { - if tt.wildcard && (testing.Short() || !*testExternal) { + if tt.wildcard && !*testExternal { continue } switch runtime.GOOS { -- 2.48.1