From 8c3d217d89e718a5d9b7d8f4b1336907f15ea50c Mon Sep 17 00:00:00 2001 From: Richard Miller Date: Tue, 4 May 2021 17:43:26 +0100 Subject: [PATCH] os: skip TestExecutableDeleted on plan9 This test deletes the running executable file, which is not safe on Plan 9. The test was working by accident prior to commit 02ab8d1, which must have changed the page reference ordering just enough to cause a new demand page-in after deletion of the file. Fixes #45941 Change-Id: Ic13d8032c21cee603e3afc3c5c4da6093fc37bf4 Reviewed-on: https://go-review.googlesource.com/c/go/+/316829 Reviewed-by: David du Colombier <0intro@gmail.com> Reviewed-by: Bryan C. Mills Trust: David du Colombier <0intro@gmail.com> Run-TryBot: David du Colombier <0intro@gmail.com> TryBot-Result: Go Bot --- src/os/executable_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/os/executable_test.go b/src/os/executable_test.go index 9ff6327149..719d6a61c3 100644 --- a/src/os/executable_test.go +++ b/src/os/executable_test.go @@ -90,8 +90,8 @@ func init() { func TestExecutableDeleted(t *testing.T) { testenv.MustHaveExec(t) switch runtime.GOOS { - case "windows": - t.Skip("windows does not support deleting running binary") + case "windows", "plan9": + t.Skipf("%v does not support deleting running binary", runtime.GOOS) case "openbsd", "freebsd", "aix": t.Skipf("%v does not support reading deleted binary name", runtime.GOOS) } -- 2.50.0