From 8cb6d3b826e25619de2f57d0aaf850a4116a2511 Mon Sep 17 00:00:00 2001 From: Jakub Ciolek Date: Sat, 8 Feb 2025 23:35:51 +0100 Subject: [PATCH] cmd/compile: mark PCMPEQB as commutative compilecmp linux/amd64: internal/runtime/maps internal/runtime/maps.(*table).Delete changed internal/runtime/maps [cmd/compile] internal/runtime/maps.(*Map).Delete changed internal/runtime/maps.(*table).Delete changed Change-Id: Ic3c95411c23cab7427e63105170de41e5766f809 Reviewed-on: https://go-review.googlesource.com/c/go/+/647935 LUCI-TryBot-Result: Go LUCI Reviewed-by: Dmitri Shuralyov Reviewed-by: Keith Randall Reviewed-by: Keith Randall Auto-Submit: Keith Randall --- src/cmd/compile/internal/ssa/_gen/AMD64Ops.go | 4 ++-- src/cmd/compile/internal/ssa/opGen.go | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/cmd/compile/internal/ssa/_gen/AMD64Ops.go b/src/cmd/compile/internal/ssa/_gen/AMD64Ops.go index 23fb2361b5..7be70c7737 100644 --- a/src/cmd/compile/internal/ssa/_gen/AMD64Ops.go +++ b/src/cmd/compile/internal/ssa/_gen/AMD64Ops.go @@ -1156,7 +1156,7 @@ func init() { // // output[i] = input. {name: "PSHUFBbroadcast", argLength: 1, reg: fp11, resultInArg0: true, asm: "PSHUFB"}, // PSHUFB with mask zero, (GOAMD64=v1) - {name: "VPBROADCASTB", argLength: 1, reg: gpfp, asm: "VPBROADCASTB"}, // Broadcast input byte from gp (GOAMD64=v3) + {name: "VPBROADCASTB", argLength: 1, reg: gpfp, asm: "VPBROADCASTB"}, // Broadcast input byte from gp (GOAMD64=v3) // Byte negate/zero/preserve (GOAMD64=v2). // @@ -1180,7 +1180,7 @@ func init() { // } else { // output[i] = 0 // } - {name: "PCMPEQB", argLength: 2, reg: fp21, resultInArg0: true, asm: "PCMPEQB"}, + {name: "PCMPEQB", argLength: 2, reg: fp21, resultInArg0: true, asm: "PCMPEQB", commutative: true}, // Byte sign mask. Output is a bitmap of sign bits from each input byte. // diff --git a/src/cmd/compile/internal/ssa/opGen.go b/src/cmd/compile/internal/ssa/opGen.go index df1ddfa69e..13ec9dc9e3 100644 --- a/src/cmd/compile/internal/ssa/opGen.go +++ b/src/cmd/compile/internal/ssa/opGen.go @@ -15414,6 +15414,7 @@ var opcodeTable = [...]opInfo{ { name: "PCMPEQB", argLen: 2, + commutative: true, resultInArg0: true, asm: x86.APCMPEQB, reg: regInfo{ -- 2.51.0