From 8cc515ad3fe9f7f45470713ff1cd4faf323aef6a Mon Sep 17 00:00:00 2001 From: Cherry Zhang Date: Wed, 1 Apr 2020 12:17:04 -0400 Subject: [PATCH] [dev.link] cmd/link: stop marking DWARF constant symbols DWARF constant symbols were always marked and converted to sym.Symbols when DWARF generation uses sym.Symbols. Now that the DWARF generation uses the loader, no need to force-mark them. Change-Id: Ia4032430697cfa901fb4b6d106a483973277ea0a Reviewed-on: https://go-review.googlesource.com/c/go/+/226803 Reviewed-by: Than McIntosh Reviewed-by: Jeremy Faller --- src/cmd/link/internal/ld/deadcode2.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/cmd/link/internal/ld/deadcode2.go b/src/cmd/link/internal/ld/deadcode2.go index 59f207b278..3342efe39f 100644 --- a/src/cmd/link/internal/ld/deadcode2.go +++ b/src/cmd/link/internal/ld/deadcode2.go @@ -6,7 +6,6 @@ package ld import ( "bytes" - "cmd/internal/dwarf" "cmd/internal/objabi" "cmd/internal/sys" "cmd/link/internal/loader" @@ -101,14 +100,6 @@ func (d *deadcodePass2) init() { names = append(names, exp) } - // DWARF constant DIE symbols are not referenced, but needed by - // the dwarf pass. - if !*FlagW { - for _, lib := range d.ctxt.Library { - names = append(names, dwarf.ConstInfoPrefix+lib.Pkg) - } - } - for _, name := range names { // Mark symbol as a data/ABI0 symbol. d.mark(d.ldr.Lookup(name, 0), 0) -- 2.50.0