From 8d212c3ac3bacdf8d135e94d1e0a0c3cfba6e13a Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Fri, 10 May 2019 15:34:17 -0400 Subject: [PATCH] cmd/go/internal/modfetch/codehost: ignore incomplete semver tags in RecentTag Fixes #31965 Change-Id: I2126903196b630c0bee2c022be1a818e0856ce3b Reviewed-on: https://go-review.googlesource.com/c/go/+/176539 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Jay Conrod --- src/cmd/go/internal/modfetch/codehost/git.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cmd/go/internal/modfetch/codehost/git.go b/src/cmd/go/internal/modfetch/codehost/git.go index 55627cb72a..272eadcb23 100644 --- a/src/cmd/go/internal/modfetch/codehost/git.go +++ b/src/cmd/go/internal/modfetch/codehost/git.go @@ -678,7 +678,8 @@ func (r *gitRepo) RecentTag(rev, prefix string) (tag string, err error) { } semtag := line[len(prefix):] - if semver.IsValid(semtag) { + // Consider only tags that are valid and complete (not just major.minor prefixes). + if c := semver.Canonical(semtag); c != "" && strings.HasPrefix(semtag, c) { highest = semver.Max(highest, semtag) } } -- 2.50.0