From 8e3930f2588a3f6d8fcaac7ef8add9c2d5dedc0e Mon Sep 17 00:00:00 2001 From: Michael Anthony Knyszek Date: Mon, 18 Dec 2023 17:03:19 +0000 Subject: [PATCH] runtime: skip TestRuntimeLockMetricsAndProfile for flakiness This test was added to check new mutex profile functionality. Specifically, it checks to make sure that the functionality behind GODEBUG=runtimecontentionstacks works. The runtime currently tracks contention from runtime-internal mutexes in mutex profiles, but it does not record stack traces for them, attributing the time to a dummy symbol. This GODEBUG enables collecting stacks. Just disable the test. Even if this functionality breaks, it won't affect Go users and it'll help keep the builders green. It's fine to leave the test because this will be revisited in the next dev cycle. For #64253. Change-Id: I7938fe0f036fc4e4a0764f030e691e312ec2c9b5 Reviewed-on: https://go-review.googlesource.com/c/go/+/550775 LUCI-TryBot-Result: Go LUCI Reviewed-by: Eli Bendersky Reviewed-by: Cherry Mui Auto-Submit: Michael Knyszek --- src/runtime/metrics_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/runtime/metrics_test.go b/src/runtime/metrics_test.go index fc0321e4c5..d7f41334cd 100644 --- a/src/runtime/metrics_test.go +++ b/src/runtime/metrics_test.go @@ -9,6 +9,7 @@ import ( "fmt" "internal/goexperiment" "internal/profile" + "internal/testenv" "os" "reflect" "runtime" @@ -947,6 +948,8 @@ func TestSchedPauseMetrics(t *testing.T) { } func TestRuntimeLockMetricsAndProfile(t *testing.T) { + testenv.SkipFlaky(t, 64253) + old := runtime.SetMutexProfileFraction(0) // enabled during sub-tests defer runtime.SetMutexProfileFraction(old) if old != 0 { -- 2.48.1