From 9049d77dbeb3e5fb3134e88fd5686438f054cb2f Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Tue, 15 Aug 2023 18:07:51 -0400 Subject: [PATCH] cmd/go: skip gccgo_link_c when cross-compiling I don't understand the rationale given in https://git.alpinelinux.org/aports/commit/community/go/tests-unset-GCCGO.patch?id=a10e9a5e48507198e26a8cf19709e4059da4c79f, but I suspect that it may be working around test failures when cross-compiling, since we have a lot of other gccgo tests that need to skip in that circumstance. Alternatively, that may just be a stale patch working around #53815. I can't fine any issue filed against the Go project for this patch, so it's hard to be sure. Either way, adding this skip should make the test more robust. For #62053. Change-Id: I44dbe9a5a24c0e2d3f22fbe6ca995160a36b2606 Reviewed-on: https://go-review.googlesource.com/c/go/+/520056 TryBot-Result: Gopher Robot Reviewed-by: Michael Matloob Run-TryBot: Bryan Mills --- src/cmd/go/testdata/script/gccgo_link_c.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cmd/go/testdata/script/gccgo_link_c.txt b/src/cmd/go/testdata/script/gccgo_link_c.txt index f6c702a167..d37cb66247 100644 --- a/src/cmd/go/testdata/script/gccgo_link_c.txt +++ b/src/cmd/go/testdata/script/gccgo_link_c.txt @@ -3,6 +3,7 @@ [!cgo] skip [!exec:gccgo] skip +[cross] skip # gccgo can't necessarily cross-compile, so don't assume it will reach the step where we expect it to fail ! go build -x -compiler gccgo stderr 'gccgo.*\-L [^ ]*alibpath \-lalib' # make sure that Go-inline "#cgo LDFLAGS:" ("-L alibpath -lalib") passed to gccgo linking stage -- 2.50.0