From 90614ff46236e970acbcb3645edd03186718667a Mon Sep 17 00:00:00 2001 From: Jeff Widman Date: Wed, 28 Apr 2021 17:21:43 +0000 Subject: [PATCH] cmd/go/internal/modfetch: fix comment that mentions no-longer returned error In c9211577eb77df9c51f0565f1da7d20ff91d59df @bcmills removed the returned error from `Lookup`. However, the function docstring still mentions that this can return an error. So this corrects the docs. Change-Id: Idca74a200dfdb024e3d7ff6c439c70632cfec11a GitHub-Last-Rev: 62eaacf70c3886d8aba25b79212c61485a89fde0 GitHub-Pull-Request: golang/go#45822 Reviewed-on: https://go-review.googlesource.com/c/go/+/314572 Reviewed-by: Bryan C. Mills Reviewed-by: Michael Matloob Run-TryBot: Bryan C. Mills TryBot-Result: Go Bot --- src/cmd/go/internal/modfetch/repo.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cmd/go/internal/modfetch/repo.go b/src/cmd/go/internal/modfetch/repo.go index 20469c5432..0bffa55af6 100644 --- a/src/cmd/go/internal/modfetch/repo.go +++ b/src/cmd/go/internal/modfetch/repo.go @@ -183,7 +183,8 @@ type lookupCacheKey struct { // from its origin, and "noproxy" indicates that the patch should be fetched // directly only if GONOPROXY matches the given path. // -// For the distinguished proxy "off", Lookup always returns a non-nil error. +// For the distinguished proxy "off", Lookup always returns a Repo that returns +// a non-nil error for every method call. // // A successful return does not guarantee that the module // has any defined versions. -- 2.50.0