From 90dbd428e5d1755bd1945ed978fea483ba557de1 Mon Sep 17 00:00:00 2001 From: David Crawshaw Date: Fri, 27 Feb 2015 08:58:54 -0500 Subject: [PATCH] runtime/pprof: skip tests that fork on darwin/arm Change-Id: I9b08b74214e5a41a7e98866a993b038030a4c073 Reviewed-on: https://go-review.googlesource.com/6251 Reviewed-by: Hyang-Ah Hana Kim --- src/runtime/pprof/pprof_test.go | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/src/runtime/pprof/pprof_test.go b/src/runtime/pprof/pprof_test.go index 2d1bfa9a48..eeb6d109dd 100644 --- a/src/runtime/pprof/pprof_test.go +++ b/src/runtime/pprof/pprof_test.go @@ -122,15 +122,16 @@ func parseProfile(t *testing.T, bytes []byte, f func(uintptr, []uintptr)) { func testCPUProfile(t *testing.T, need []string, f func()) { switch runtime.GOOS { case "darwin": - out, err := exec.Command("uname", "-a").CombinedOutput() - if err != nil { - t.Fatal(err) + if runtime.GOARCH != "arm" { + out, err := exec.Command("uname", "-a").CombinedOutput() + if err != nil { + t.Fatal(err) + } + vers := string(out) + t.Logf("uname -a: %v", vers) } - vers := string(out) - t.Logf("uname -a: %v", vers) case "plan9": - // unimplemented - return + t.Skip("skipping on plan9") } var prof bytes.Buffer @@ -200,6 +201,12 @@ func testCPUProfile(t *testing.T, need []string, f func()) { } func TestCPUProfileWithFork(t *testing.T) { + if runtime.GOOS == "darwin" { + if runtime.GOARCH == "arm" { + t.Skipf("skipping on darwin/arm") + } + } + // Fork can hang if preempted with signals frequently enough (see issue 5517). // Ensure that we do not do this. heap := 1 << 30 -- 2.48.1