From 91a1b55489dfdc720ee4043390777e903c69222a Mon Sep 17 00:00:00 2001 From: cuiweixie Date: Sun, 4 Sep 2022 17:47:17 +0800 Subject: [PATCH] flag: use strings.Builder Change-Id: Iee846c4ac0f111ff97aa618dd42f6b2d14aa4342 Reviewed-on: https://go-review.googlesource.com/c/go/+/428259 TryBot-Result: Gopher Robot Reviewed-by: Robert Griesemer Reviewed-by: Ian Lance Taylor Auto-Submit: Ian Lance Taylor Run-TryBot: Ian Lance Taylor --- src/flag/flag_test.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/flag/flag_test.go b/src/flag/flag_test.go index ca6ba5d149..791a8826be 100644 --- a/src/flag/flag_test.go +++ b/src/flag/flag_test.go @@ -5,7 +5,6 @@ package flag_test import ( - "bytes" . "flag" "fmt" "internal/testenv" @@ -358,7 +357,7 @@ func TestUserDefinedBool(t *testing.T) { func TestSetOutput(t *testing.T) { var flags FlagSet - var buf bytes.Buffer + var buf strings.Builder flags.SetOutput(&buf) flags.Init("test", ContinueOnError) flags.Parse([]string{"-unknown"}) @@ -488,7 +487,7 @@ panic calling String method on zero flag_test.zeroPanicker for flag ZP1: panic! func TestPrintDefaults(t *testing.T) { fs := NewFlagSet("print defaults test", ContinueOnError) - var buf bytes.Buffer + var buf strings.Builder fs.SetOutput(&buf) fs.Bool("A", false, "for bootstrapping, allow 'any' type") fs.Bool("Alongflagname", false, "disable bounds checking") @@ -531,7 +530,7 @@ func TestIntFlagOverflow(t *testing.T) { // Issue 20998: Usage should respect CommandLine.output. func TestUsageOutput(t *testing.T) { ResetForTesting(DefaultUsage) - var buf bytes.Buffer + var buf strings.Builder CommandLine.SetOutput(&buf) defer func(old []string) { os.Args = old }(os.Args) os.Args = []string{"app", "-i=1", "-unknown"} @@ -726,7 +725,7 @@ func TestInvalidFlags(t *testing.T) { testName := fmt.Sprintf("FlagSet.Var(&v, %q, \"\")", test.flag) fs := NewFlagSet("", ContinueOnError) - buf := bytes.NewBuffer(nil) + buf := &strings.Builder{} fs.SetOutput(buf) mustPanic(t, testName, test.errorMsg, func() { @@ -758,7 +757,7 @@ func TestRedefinedFlags(t *testing.T) { testName := fmt.Sprintf("flag redefined in FlagSet(%q)", test.flagSetName) fs := NewFlagSet(test.flagSetName, ContinueOnError) - buf := bytes.NewBuffer(nil) + buf := &strings.Builder{} fs.SetOutput(buf) var v flagVar -- 2.48.1