From 92261b38638af61a3aae2fdc48fd0b9f0cbff096 Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Wed, 29 Mar 2023 18:03:26 -0400 Subject: [PATCH] run.bash: drop 'export GOROOT' and its obsolete comment The comment justifies exporting GOROOT by saying the api test needs it, which was relevant back when it was added in CL 99870043, but isn't true by now. As of Go 1.8, GOPATH can be unset (https://go.dev/doc/go1.8#gopath). At some point it also became okay to leave GOROOT unset, at least whenever one is looking to use the default GOROOT tree of the go command being executed and not intentionally changing it to a custom directory. It's also not there in the .bat and .rc variants of this script. Drop it. Change-Id: Ibcb386c560523fcfbfec8020f90692dcfa5aa686 Reviewed-on: https://go-review.googlesource.com/c/go/+/480376 Reviewed-by: Dmitri Shuralyov TryBot-Result: Gopher Robot Reviewed-by: Michael Knyszek Auto-Submit: Dmitri Shuralyov Run-TryBot: Dmitri Shuralyov --- src/run.bash | 1 - 1 file changed, 1 deletion(-) diff --git a/src/run.bash b/src/run.bash index 6274df6fb3..badb8c60e2 100755 --- a/src/run.bash +++ b/src/run.bash @@ -31,7 +31,6 @@ fi export GOENV=off eval $(../bin/go tool dist env) -export GOROOT # The api test requires GOROOT to be set, so set it to match ../bin/go. unset CDPATH # in case user has it set -- 2.48.1